Pointing frame code #759
Merged
Pointing frame code #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imap_processing/tests/pointing_frame/test_data/imap_science_0001.tf
Outdated
Show resolved
Hide resolved
imap_processing/tests/pointing_frame/test_data/imap_sclk_0000.tsc
Outdated
Show resolved
Hide resolved
imap_processing/tests/pointing_frame/test_pointing_frame_handler.py
Outdated
Show resolved
Hide resolved
imap_processing/tests/pointing_frame/test_pointing_frame_handler.py
Outdated
Show resolved
Hide resolved
imap_processing/tests/pointing_frame/test_pointing_frame_handler.py
Outdated
Show resolved
Hide resolved
imap_processing/tests/pointing_frame/test_pointing_frame_handler.py
Outdated
Show resolved
Hide resolved
laspsandoval
force-pushed
the
dps_frame_transfer
branch
from
d78c60b
to
804c3ac
Compare
greglucas
reviewed
Aug 20, 2024
greglucas
reviewed
Aug 21, 2024
greglucas
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Thank you for taking the time to address all of the feedback, I know there was a lot of it which can sometimes be hard to keep track of. I think this reads really nicely now, great work on this!
I just have a few minor nitpicks and I agree with all of Tim's comments so those should be addressed before merging too.
laspsandoval
merged commit 8ef0cb6
into
IMAP-Science-Operations-Center:dev
17 checks passed
|
Just as a note that we should discuss in a future tag-up. Because @subagonsouth had comments I think his approval should have been waited for. I approved suggesting my comments were sufficient, but thought maybe Tim should take another look before merging. |
This was
linked to
issues
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Provides algorithm that mocks Nick Duttons pointing frame (DPS frame) kernel generation. Note that I have TODOs that will be included in the next tickets.
New Files
Testing